lkml.org 
[lkml]   [2022]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [Patch V1 1/4] memory: tegra: Add support for mc interrupts
From
On 11/01/2022 19:45, Ashish Mhetre wrote:
> Implement new structure for function related to mc interrupts.

s/mc/MC/

> Move handle_irq into this structure.
> Add support for clearing interrupts.

The subject says you are adding support for MC interrupts, so before
they were not supported at all?

Here you also mention clearing of interrupts - another new feature. One
commit for refactoring (adding new structure) which does not change
functionality, second commit for adding new feature.

Different question - why do you need new structure for just two function
pointers? Why these different IRQ handling functions cannot be in
tegra_mc_ops? To me, it's unnecessary code complexity (plus performance
impact, but it's not that important). If this is really, really needed,
please describe the rationale in the commit message.

>
> Signed-off-by: Ashish Mhetre <amhetre@nvidia.com>
> ---
> drivers/memory/tegra/mc.c | 14 +++++++++++---
> drivers/memory/tegra/mc.h | 1 +
> drivers/memory/tegra/tegra114.c | 1 +
> drivers/memory/tegra/tegra124.c | 2 ++
> drivers/memory/tegra/tegra186.c | 14 ++++++++++++++
> drivers/memory/tegra/tegra194.c | 12 ++++++++++++
> drivers/memory/tegra/tegra20.c | 6 +++++-
> drivers/memory/tegra/tegra210.c | 1 +
> drivers/memory/tegra/tegra30.c | 1 +
> include/soc/tegra/mc.h | 7 ++++++-
> 10 files changed, 54 insertions(+), 5 deletions(-)
>


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-01-11 21:31    [W:0.403 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site