lkml.org 
[lkml]   [2022]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] ASoC: dt-bindings: add bindings for TI TAS5805M.
On Tue, Jan 11, 2022 at 01:00:09PM +1300, Daniel Beer wrote:

> + ti,dsp-config: |
> + description: |
> + A byte sequence giving DSP configuration. Each pair of bytes, in
> + sequence, gives a register address and a value to write. If you
> + are taking this data from TI's PPC3 tool, this should contain only
> + the register writes following the 5ms delay.

This doesn't look appropriate for DT, it looks more like it should be
loaded as firmware since systems might want to support multiple
configurations at runtime based on use casea. It would also be good to
have code to validate that any supplied coefficeints/firmware don't
overwrite registers managed by the driver, just in case.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-01-11 18:26    [W:1.022 / U:0.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site