Messages in this thread | | | Subject | Re: [PATCH 09/14] ipv6: hand dst refs to cork setup | From | Paolo Abeni <> | Date | Tue, 11 Jan 2022 18:11:03 +0100 |
| |
On Tue, 2022-01-11 at 01:21 +0000, Pavel Begunkov wrote: > During cork->dst setup, ip6_make_skb() gets an additional reference to > a passed in dst. However, udpv6_sendmsg() doesn't need dst after calling > ip6_make_skb(), and so we can save two additional atomics by passing > dst references to ip6_make_skb(). udpv6_sendmsg() is the only caller, so > it's enough to make sure it doesn't use dst afterwards.
What about the corked path in udp6_sendmsg()? I mean:
udp6_sendmsg(MSG_MORE) -> ip6_append_data() -> ip6_setup_cork()
what if ip6_setup_cork() errors out in that path?
Thanks!
Paolo
| |