Messages in this thread | | | Subject | Re: [PATCH 1/7] pinctrl: pinconf-generic: Print arguments for bias-pull-* | From | AngeloGioacchino Del Regno <> | Date | Tue, 11 Jan 2022 14:42:27 +0100 |
| |
Il 11/01/22 12:22, Chen-Yu Tsai ha scritto: > The bias-pull-* properties, or PIN_CONFIG_BIAS_PULL_* pin config > parameters, accept optional arguments in ohms denoting the strength of > the pin bias. > > Print these values out in debugfs as well. > > Fixes: eec450713e5c ("pinctrl: pinconf-generic: Add flag to print arguments") > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Tested on qcom-SC7180 Trogdor, mtk-MT8173 Elm, and others;
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> --- > drivers/pinctrl/pinconf-generic.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/pinctrl/pinconf-generic.c b/drivers/pinctrl/pinconf-generic.c > index f8edcc88ac01..415d1df8f46a 100644 > --- a/drivers/pinctrl/pinconf-generic.c > +++ b/drivers/pinctrl/pinconf-generic.c > @@ -30,10 +30,10 @@ static const struct pin_config_item conf_items[] = { > PCONFDUMP(PIN_CONFIG_BIAS_BUS_HOLD, "input bias bus hold", NULL, false), > PCONFDUMP(PIN_CONFIG_BIAS_DISABLE, "input bias disabled", NULL, false), > PCONFDUMP(PIN_CONFIG_BIAS_HIGH_IMPEDANCE, "input bias high impedance", NULL, false), > - PCONFDUMP(PIN_CONFIG_BIAS_PULL_DOWN, "input bias pull down", NULL, false), > + PCONFDUMP(PIN_CONFIG_BIAS_PULL_DOWN, "input bias pull down", "ohms", true), > PCONFDUMP(PIN_CONFIG_BIAS_PULL_PIN_DEFAULT, > - "input bias pull to pin specific state", NULL, false), > - PCONFDUMP(PIN_CONFIG_BIAS_PULL_UP, "input bias pull up", NULL, false), > + "input bias pull to pin specific state", "ohms", true), > + PCONFDUMP(PIN_CONFIG_BIAS_PULL_UP, "input bias pull up", "ohms", true), > PCONFDUMP(PIN_CONFIG_DRIVE_OPEN_DRAIN, "output drive open drain", NULL, false), > PCONFDUMP(PIN_CONFIG_DRIVE_OPEN_SOURCE, "output drive open source", NULL, false), > PCONFDUMP(PIN_CONFIG_DRIVE_PUSH_PULL, "output drive push pull", NULL, false), >
| |