Messages in this thread | | | Subject | Re: [PATCH 3/7] pinctrl: mediatek: paris: Fix "argument" argument type for mtk_pinconf_get() | From | AngeloGioacchino Del Regno <> | Date | Tue, 11 Jan 2022 14:42:26 +0100 |
| |
Il 11/01/22 12:22, Chen-Yu Tsai ha scritto: > For mtk_pinconf_get(), the "argument" argument is typically returned by > pinconf_to_config_argument(), which holds the value for a given pinconf > parameter. It certainly should not have the type of "enum pin_config_param", > which describes the type of the pinconf parameter itself. > > Change the type to u32, which matches the return type of > pinconf_to_config_argument(). > > Fixes: 805250982bb5 ("pinctrl: mediatek: add pinctrl-paris that implements the vendor dt-bindings") > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> --- > drivers/pinctrl/mediatek/pinctrl-paris.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c > index 1ca598ea7ba7..d720624d8cd2 100644 > --- a/drivers/pinctrl/mediatek/pinctrl-paris.c > +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c > @@ -188,8 +188,7 @@ static int mtk_pinconf_get(struct pinctrl_dev *pctldev, > } > > static int mtk_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin, > - enum pin_config_param param, > - enum pin_config_param arg) > + enum pin_config_param param, u32 arg) > { > struct mtk_pinctrl *hw = pinctrl_dev_get_drvdata(pctldev); > const struct mtk_pin_desc *desc; >
| |