Messages in this thread | | | Subject | Re: [PATCH 6/7] pinctrl: mediatek: paris: Skip custom extra pin config dump for vrtual GPIOs | From | AngeloGioacchino Del Regno <> | Date | Tue, 11 Jan 2022 14:41:52 +0100 |
| |
Il 11/01/22 12:22, Chen-Yu Tsai ha scritto: > Virtual GPIOs do not have any hardware state associated with them. Any > attempt to read back hardware state for these pins result in error > codes. > > Skip dumping extra pin config information for these virtual GPIOs. > > Fixes: 184d8e13f9b1 ("pinctrl: mediatek: Add support for pin configuration dump via debugfs.") > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Can you please fix the typo in the commit title? "vrtual"->"virtual"
After the typo fix:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Thank you!
> --- > drivers/pinctrl/mediatek/pinctrl-paris.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c > index 1bacabfbc183..678c8aa33012 100644 > --- a/drivers/pinctrl/mediatek/pinctrl-paris.c > +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c > @@ -585,6 +585,9 @@ ssize_t mtk_pctrl_show_one_pin(struct mtk_pinctrl *hw, > if (gpio >= hw->soc->npins) > return -EINVAL; > > + if (mtk_is_virt_gpio(hw, gpio)) > + return -EINVAL; > + > desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio]; > pinmux = mtk_pctrl_get_pinmux(hw, gpio); > if (pinmux >= hw->soc->nfuncs) >
| |