Messages in this thread | | | From | "Penigalapati, Sandeep" <> | Subject | RE: [Intel-wired-lan] [PATCH v4 net-next 9/9] ixgbe: respect metadata on XSK Rx to skb | Date | Tue, 11 Jan 2022 11:52:12 +0000 |
| |
>-----Original Message----- >From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of >Alexander Lobakin >Sent: Wednesday, December 8, 2021 7:37 PM >To: intel-wired-lan@lists.osuosl.org >Cc: Song Liu <songliubraving@fb.com>; Alexei Starovoitov <ast@kernel.org>; >Andrii Nakryiko <andrii@kernel.org>; Daniel Borkmann ><daniel@iogearbox.net>; John Fastabend <john.fastabend@gmail.com>; >Jesper Dangaard Brouer <brouer@redhat.com>; Yonghong Song ><yhs@fb.com>; Jesper Dangaard Brouer <hawk@kernel.org>; KP Singh ><kpsingh@kernel.org>; Jakub Kicinski <kuba@kernel.org>; >netdev@vger.kernel.org; linux-kernel@vger.kernel.org; David S. Miller ><davem@davemloft.net>; Björn Töpel <bjorn@kernel.org>; >bpf@vger.kernel.org; Martin KaFai Lau <kafai@fb.com> >Subject: [Intel-wired-lan] [PATCH v4 net-next 9/9] ixgbe: respect metadata on >XSK Rx to skb > >For now, if the XDP prog returns XDP_PASS on XSK, the metadata will be lost >as it doesn't get copied to the skb. >Copy it along with the frame headers. Account its size on skb allocation, and >when copying just treat it as a part of the frame and do a pull after to "move" >it to the "reserved" zone. >net_prefetch() xdp->data_meta and align the copy size to speed-up >memcpy() a little and better match ixgbe_costruct_skb(). > >Fixes: d0bcacd0a130 ("ixgbe: add AF_XDP zero-copy Rx support") >Suggested-by: Jesper Dangaard Brouer <brouer@redhat.com> >Suggested-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com> >Signed-off-by: Alexander Lobakin <alexandr.lobakin@intel.com> >Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com> >--- > drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > Tested-by: Sandeep Penigalapati <sandeep.penigalapati@intel.com>
| |