Messages in this thread | | | Date | Tue, 11 Jan 2022 09:29:09 +0100 | Subject | Re: [PATCH V2] tty: serial: fsl_lpuart: count tty buffer overruns | From | Jiri Slaby <> |
| |
On 11. 01. 22, 9:22, Sherry Sun wrote: > Added support for counting the tty buffer overruns in fsl_lpuart driver > like other uart drivers. > > Signed-off-by: Sherry Sun <sherry.sun@nxp.com> > > --- > changes in V2 > 1. Change the copied type to int to avoid implicit conversion, as the > tty_insert_flip_string return type is int. > --- > drivers/tty/serial/fsl_lpuart.c | 20 +++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) > > diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c > index ce3e26144689..82a1a2817750 100644 > --- a/drivers/tty/serial/fsl_lpuart.c > +++ b/drivers/tty/serial/fsl_lpuart.c ... > @@ -1116,7 +1118,7 @@ static void lpuart_copy_rx_to_tty(struct lpuart_port *sport) > struct dma_chan *chan = sport->dma_rx_chan; > struct circ_buf *ring = &sport->rx_ring; > unsigned long flags; > - int count = 0; > + int count = 0, copied = 0;
Why is it necessary to initialize copied?
Actually neither count needs to be initialized AFAICT. Care to fix that too (in a separate patch).
thanks, -- js suse labs
| |