Messages in this thread | | | Subject | Re: [PATCH] scsi: Do not break scan luns loop if add single lun failed | From | Wenchao Hao <> | Date | Wed, 12 Jan 2022 10:28:36 +0800 |
| |
On 2021/12/26 7:29, Wenchao Hao wrote: > Failed to add a single lun does not mean all luns are unaccessible, > if we break the scan luns loop, the other luns reported by REPORT LUNS > command would not be probed any more. > > In this case, we might loss some luns which are accessible. > > Signed-off-by: Wenchao Hao <haowenchao@huawei.com> > --- > drivers/scsi/scsi_scan.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c > index 23e1c0acdeae..fee7ce082103 100644 > --- a/drivers/scsi/scsi_scan.c > +++ b/drivers/scsi/scsi_scan.c > @@ -1476,13 +1476,13 @@ static int scsi_report_lun_scan(struct scsi_target *starget, blist_flags_t bflag > lun, NULL, NULL, rescan, NULL); > if (res == SCSI_SCAN_NO_RESPONSE) { > /* > - * Got some results, but now none, abort. > + * Got some results, but now none, abort this lun > */ > sdev_printk(KERN_ERR, sdev, > "Unexpected response" > " from lun %llu while scanning, scan" > " aborted\n", (unsigned long long)lun); > - break; > + continue; > } > } > } >
ping ...
| |