Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: [PATCH v5] powerpc/pseries: read the lpar name from the firmware | Date | Wed, 12 Jan 2022 09:40:27 +1100 |
| |
Tyrel Datwyler <tyreld@linux.ibm.com> writes: > On 1/6/22 8:13 AM, Laurent Dufour wrote: >> The LPAR name may be changed after the LPAR has been started in the HMC. >> In that case lparstat command is not reporting the updated value because it >> reads it from the device tree which is read at boot time. >> >> However this value could be read from RTAS. >> >> Adding this value in the /proc/powerpc/lparcfg output allows to read the >> updated value. >> >> However the hypervisor, like Qemu/KVM, may not support this RTAS >> parameter. In that case the value reported in lparcfg is read from the >> device tree and so is not updated accordingly. >> >> Cc: Nathan Lynch <nathanl@linux.ibm.com> >> Signed-off-by: Laurent Dufour <ldufour@linux.ibm.com> > > My only nit would be that in general for consistency with other function names > _RTAS_ and _DT_ should be lowercase. Seeing as they are statically scoped within > lparcfg.c maybe its ok. Otherwise,
Yeah I agree, I changed them to lower case when applying.
cheers
| |