Messages in this thread | | | From | Martin Blumenstingl <> | Date | Mon, 10 Jan 2022 23:18:33 +0100 | Subject | Re: [PATCH v3 1/2] dt-bindings: phy: add Amlogic G12A Analog MIPI D-PHY bindings |
| |
Hi Neil,
On Mon, Jan 10, 2022 at 10:25 AM Neil Armstrong <narmstrong@baylibre.com> wrote: > > On 07/01/2022 23:13, Martin Blumenstingl wrote: > > Hi Neil, > > > > On Fri, Jan 7, 2022 at 4:05 PM Neil Armstrong <narmstrong@baylibre.com> wrote: > > [...] > >> +required: > >> + - compatible > >> + - reg > >> + - "#phy-cells" > > I also found a "MIPI DSI PHY clock" and "MIPI DSI PHY interrupt" in > > the datasheet. > > I'm no expert on this and I'm just asking in case you have missed one of these: > > Can you confirm that these belong to some other IP? > > Indeed the name is misleading, both go to the DSI Transceiver IP (dw-mipi-dsi) Thank you for clarifying this!
I just found an old comment from Rob on v2 of this series: [0] He mentions: "If this is a child of something else, then put a $ref to this schema and the example in the parent schema."
To be honest: I completely forgot about that comment until now. If I had remembered it (and assuming that his comment is still valid) then I would have had to NACK my own Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml For today it's already late so I'll look into this more tomorrow.
Best regards, Martin
[0] https://lore.kernel.org/all/20210210165118.GA2311581@robh.at.kernel.org/
| |