lkml.org 
[lkml]   [2022]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 17/21] usb: mtu3: fix interval value for intr and isoc
    Date
    From: Chunfeng Yun <chunfeng.yun@mediatek.com>

    [ Upstream commit e3d4621c22f90c33321ae6a6baab60cdb8e5a77c ]

    Use the Interval value from isoc/intr endpoint descriptor, no need
    minus one. The original code doesn't cause transfer error for
    normal cases, but it may have side effect with respond time of ERDY
    or tPingTimeout.

    Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
    Link: https://lore.kernel.org/r/20211218095749.6250-1-chunfeng.yun@mediatek.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/mtu3/mtu3_gadget.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/usb/mtu3/mtu3_gadget.c b/drivers/usb/mtu3/mtu3_gadget.c
    index 07a6ee8db6123..9f0c949820bf7 100644
    --- a/drivers/usb/mtu3/mtu3_gadget.c
    +++ b/drivers/usb/mtu3/mtu3_gadget.c
    @@ -82,7 +82,7 @@ static int mtu3_ep_enable(struct mtu3_ep *mep)
    if (usb_endpoint_xfer_int(desc) ||
    usb_endpoint_xfer_isoc(desc)) {
    interval = desc->bInterval;
    - interval = clamp_val(interval, 1, 16) - 1;
    + interval = clamp_val(interval, 1, 16);
    if (usb_endpoint_xfer_isoc(desc) && comp_desc)
    mult = comp_desc->bmAttributes;
    }
    @@ -94,7 +94,7 @@ static int mtu3_ep_enable(struct mtu3_ep *mep)
    if (usb_endpoint_xfer_isoc(desc) ||
    usb_endpoint_xfer_int(desc)) {
    interval = desc->bInterval;
    - interval = clamp_val(interval, 1, 16) - 1;
    + interval = clamp_val(interval, 1, 16);
    mult = usb_endpoint_maxp_mult(desc) - 1;
    }
    break;
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-10 08:31    [W:4.060 / U:0.248 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site