lkml.org 
[lkml]   [2021]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.13 010/219] media: ti-vpe: cal: fix queuing of the initial buffer
    Date
    From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

    [ Upstream commit 892c37f8a3d673b945e951a8754695c119a2b1b0 ]

    When starting streaming the driver currently programs the buffer
    address to the CAL base-address register and assigns the buffer pointer
    to ctx->dma.pending. This is not correct, as the buffer is not
    "pending", but active, and causes the first buffer to be needlessly
    written twice.

    Fix this by assigning the buffer pointer to ctx->dma.active.

    Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
    Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/platform/ti-vpe/cal-video.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/media/platform/ti-vpe/cal-video.c b/drivers/media/platform/ti-vpe/cal-video.c
    index 7b7436a355ee..b9405f70af9f 100644
    --- a/drivers/media/platform/ti-vpe/cal-video.c
    +++ b/drivers/media/platform/ti-vpe/cal-video.c
    @@ -694,7 +694,7 @@ static int cal_start_streaming(struct vb2_queue *vq, unsigned int count)

    spin_lock_irq(&ctx->dma.lock);
    buf = list_first_entry(&ctx->dma.queue, struct cal_buffer, list);
    - ctx->dma.pending = buf;
    + ctx->dma.active = buf;
    list_del(&buf->list);
    spin_unlock_irq(&ctx->dma.lock);

    --
    2.30.2
    \
     
     \ /
      Last update: 2021-09-09 14:11    [W:4.126 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site