lkml.org 
[lkml]   [2021]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.14 244/252] parport: remove non-zero check on count
    Date
    From: Colin Ian King <colin.king@canonical.com>

    [ Upstream commit 0be883a0d795d9146f5325de582584147dd0dcdc ]

    The check for count appears to be incorrect since a non-zero count
    check occurs a couple of statements earlier. Currently the check is
    always false and the dev->port->irq != PARPORT_IRQ_NONE part of the
    check is never tested and the if statement is dead-code. Fix this
    by removing the check on count.

    Note that this code is pre-git history, so I can't find a sha for
    it.

    Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Addresses-Coverity: ("Logically dead code")
    Link: https://lore.kernel.org/r/20210730100710.27405-1-colin.king@canonical.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/parport/ieee1284_ops.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/parport/ieee1284_ops.c b/drivers/parport/ieee1284_ops.c
    index 2c11bd3fe1fd..17061f1df0f4 100644
    --- a/drivers/parport/ieee1284_ops.c
    +++ b/drivers/parport/ieee1284_ops.c
    @@ -518,7 +518,7 @@ size_t parport_ieee1284_ecp_read_data (struct parport *port,
    goto out;

    /* Yield the port for a while. */
    - if (count && dev->port->irq != PARPORT_IRQ_NONE) {
    + if (dev->port->irq != PARPORT_IRQ_NONE) {
    parport_release (dev);
    schedule_timeout_interruptible(msecs_to_jiffies(40));
    parport_claim_or_block (dev);
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-09-09 14:07    [W:2.272 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site