lkml.org 
[lkml]   [2021]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.14 206/252] mmc: core: Avoid hogging the CPU while polling for busy for mmc ioctls
    Date
    From: Ulf Hansson <ulf.hansson@linaro.org>

    [ Upstream commit 468108155b0f89cc08189cc33f9bacfe9da8a125 ]

    When __mmc_blk_ioctl_cmd() calls card_busy_detect() to verify that the
    card's states moves back into transfer state, the polling with CMD13 is
    done without any delays in between the commands being sent.

    Rather than fixing card_busy_detect() in this regards, let's instead
    convert into using the common mmc_poll_for_busy(), which also helps us to
    avoid open-coding.

    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
    Link: https://lore.kernel.org/r/20210702134229.357717-3-ulf.hansson@linaro.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mmc/core/block.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
    index 170343411f53..c30d0ab15539 100644
    --- a/drivers/mmc/core/block.c
    +++ b/drivers/mmc/core/block.c
    @@ -605,7 +605,8 @@ static int __mmc_blk_ioctl_cmd(struct mmc_card *card, struct mmc_blk_data *md,
    * Ensure RPMB/R1B command has completed by polling CMD13
    * "Send Status".
    */
    - err = card_busy_detect(card, MMC_BLK_TIMEOUT_MS, NULL);
    + err = mmc_poll_for_busy(card, MMC_BLK_TIMEOUT_MS, false,
    + MMC_BUSY_IO);
    }

    return err;
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-09-09 14:07    [W:2.987 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site