lkml.org 
[lkml]   [2021]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.14 084/252] drm/amd/display: Fix PSR command version
    Date
    From: Mikita Lipski <mikita.lipski@amd.com>

    [ Upstream commit af1f2b19fd7d404d299355cc95930efee5b3ed8b ]

    [why]
    For dual eDP when setting the new settings we need to set
    command version to DMUB_CMD_PSR_CONTROL_VERSION_1, otherwise
    DMUB will not read panel_inst parameter.
    [how]
    Instead of PSR_VERSION_1 pass DMUB_CMD_PSR_CONTROL_VERSION_1

    Reviewed-by: Wood Wyatt <Wyatt.Wood@amd.com>
    Acked-by: Solomon Chiu <solomon.chiu@amd.com>
    Signed-off-by: Mikita Lipski <mikita.lipski@amd.com>
    Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c b/drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c
    index 10d42ae0cffe..3428334c6c57 100644
    --- a/drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c
    +++ b/drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c
    @@ -207,7 +207,7 @@ static void dmub_psr_set_level(struct dmub_psr *dmub, uint16_t psr_level, uint8_
    cmd.psr_set_level.header.sub_type = DMUB_CMD__PSR_SET_LEVEL;
    cmd.psr_set_level.header.payload_bytes = sizeof(struct dmub_cmd_psr_set_level_data);
    cmd.psr_set_level.psr_set_level_data.psr_level = psr_level;
    - cmd.psr_set_level.psr_set_level_data.cmd_version = PSR_VERSION_1;
    + cmd.psr_set_level.psr_set_level_data.cmd_version = DMUB_CMD_PSR_CONTROL_VERSION_1;
    cmd.psr_set_level.psr_set_level_data.panel_inst = panel_inst;
    dc_dmub_srv_cmd_queue(dc->dmub_srv, &cmd);
    dc_dmub_srv_cmd_execute(dc->dmub_srv);
    @@ -293,7 +293,7 @@ static bool dmub_psr_copy_settings(struct dmub_psr *dmub,
    copy_settings_data->debug.bitfields.use_hw_lock_mgr = 1;
    copy_settings_data->fec_enable_status = (link->fec_state == dc_link_fec_enabled);
    copy_settings_data->fec_enable_delay_in100us = link->dc->debug.fec_enable_delay_in100us;
    - copy_settings_data->cmd_version = PSR_VERSION_1;
    + copy_settings_data->cmd_version = DMUB_CMD_PSR_CONTROL_VERSION_1;
    copy_settings_data->panel_inst = panel_inst;

    dc_dmub_srv_cmd_queue(dc->dmub_srv, &cmd);
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-09-09 13:48    [W:2.480 / U:0.356 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site