lkml.org 
[lkml]   [2021]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.14 057/252] nfp: fix return statement in nfp_net_parse_meta()
    Date
    From: Niklas Söderlund <niklas.soderlund@corigine.com>

    [ Upstream commit 4431531c482a2c05126caaa9fcc5053a4a5c495b ]

    The return type of the function is bool and while NULL do evaluate to
    false it's not very nice, fix this by explicitly returning false. There
    is no functional change.

    Signed-off-by: Niklas Söderlund <niklas.soderlund@corigine.com>
    Signed-off-by: Louis Peens <louis.peens@corigine.com>
    Signed-off-by: Simon Horman <simon.horman@corigine.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
    index 5dfa4799c34f..ed2ade2a4f04 100644
    --- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
    +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
    @@ -1697,7 +1697,7 @@ nfp_net_parse_meta(struct net_device *netdev, struct nfp_meta_parsed *meta,
    case NFP_NET_META_RESYNC_INFO:
    if (nfp_net_tls_rx_resync_req(netdev, data, pkt,
    pkt_len))
    - return NULL;
    + return false;
    data += sizeof(struct nfp_net_tls_resync_req);
    break;
    default:
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-09-09 13:46    [W:4.047 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site