Messages in this thread | | | Date | Thu, 9 Sep 2021 07:19:25 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] sysfs: Remove page boundary align limitation on sysfs_emit and sysfs_emit_at |
| |
On Wed, Sep 08, 2021 at 03:33:51PM +0000, Yu, Lang wrote: > >Please feel free to add better documentation for the functions if you feel people > >are getting confused, do not change the existing behavior of the code as it rightly > >caught it being misused. > > You can find many patches named "convert sysfs scnprintf/snprintf to syfs_emit/sysfs_emit_at". > or "use sysfs_emit/sysfs_emit_at in show functions". They may think it's better to use syfs_emit/sysfs_emit_at > given its overrun avoidance.
Yes, and using that in sysfs functions is fine, there is nothing wrong with this usage.
> But there are still some corner cases(e.g., a non page boundary aligned buf address : ).
I need a specific example of where this has gone wrong. Please provide a lore.kernel.org link as I fail to see the problem here.
Are you sure that you are not just abusing sysfs and having more than one value per file? Does this mean I need to go audit all of the gpu sysfs file entries?
thanks,
greg k-h
| |