lkml.org 
[lkml]   [2021]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v7 01/19] iov_iter: Fix iov_iter_get_pages{,_alloc} page fault return value
    On Fri, Aug 27, 2021 at 06:49:08PM +0200, Andreas Gruenbacher wrote:
    > Both iov_iter_get_pages and iov_iter_get_pages_alloc return the number
    > of bytes of the iovec they could get the pages for. When they cannot
    > get any pages, they're supposed to return 0, but when the start of the
    > iovec isn't page aligned, the calculation goes wrong and they return a
    > negative value. Fix both functions.
    >
    > In addition, change iov_iter_get_pages_alloc to return NULL in that case
    > to prevent resource leaks.
    >
    > Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>

    Looks good,

    Reviewed-by: Christoph Hellwig <hch@lst.de>

    \
     
     \ /
      Last update: 2021-09-09 13:12    [W:4.031 / U:0.924 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site