lkml.org 
[lkml]   [2021]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 00/15] Introduce block device LED trigger
    Dear Ian,

    I have tried to look into this and replied to some of your patches.

    There are still many things to do, and I think the reviewing would be
    much easier to review if you sent all the code changes as one patch
    (since the changes are doing an atomic change: adding support for blkdev
    LED trigger). Keep only the sysfs doc change in a separate patch.

    You are unnecessary using the const keyword in places where it is not
    needed and not customary for Linux kernel codebase. See in another of
    my replies.

    You are using a weird comment style, i.e.
    /*
    *
    * Disassociate an LED from the trigger
    *
    */

    static void blkdev_deactivate(struct led_classdev *const led_dev)

    Please look at how functions are documented in led-class.c, for example.

    There are many other things I would like you to change and fix,
    I will comment on them once you send this proposal as two commits:
    one sysfs docs change, one code change.

    Marek

    \
     
     \ /
      Last update: 2021-09-10 04:11    [W:4.693 / U:0.868 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site