Messages in this thread | | | Date | Thu, 9 Sep 2021 18:52:27 -0700 | From | Kees Cook <> | Subject | Re: [PATCH] rapidio: Avoid bogus __alloc_size warning |
| |
On Thu, Sep 09, 2021 at 04:11:09PM -0700, Andrew Morton wrote: > On Thu, 9 Sep 2021 15:51:23 -0700 Kees Cook <keescook@chromium.org> wrote: > > > > That's an "error", not a warning. Or is this thanks to the new -Werror? > > > > This is a "regular" error (__bad_copy_to() uses __compiletime_error()). > > > > > Either way, I'm inclined to cc:stable on this, because use of gcc-9 on > > > older kernels will be a common thing down the ages. > > > > > > If it's really an "error" on non-Werror kernels then definitely cc:stable. > > > > I would expect that as only being needed if __alloc_size was backported > > to -stable, which seems unlikely. > > Ah. Changelog didn't tell me that it's an __alloc_size thing.
Er, it's in the Subject, but I guess I could repeat it?
> What's the status of the __alloc_size() patchset, btw?
It's in -next via -mm, and all is well as far as I know:
compiler-attributes-add-__alloc_size-for-better-bounds-checking.patch compiler-attributes-add-__alloc_size-for-better-bounds-checking-fix.patch checkpatch-add-__alloc_size-to-known-attribute.patch slab-clean-up-function-declarations.patch slab-add-__alloc_size-attributes-for-better-bounds-checking.patch mm-page_alloc-add-__alloc_size-attributes-for-better-bounds-checking.patch percpu-add-__alloc_size-attributes-for-better-bounds-checking.patch mm-vmalloc-add-__alloc_size-attributes-for-better-bounds-checking.patch
FWIW, I had extensively checked (and fixed) warnings from it before sending it your way. This patch is fixing an error that just appeared from randconfig.
-Kees
-- Kees Cook
| |