lkml.org 
[lkml]   [2021]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 04/15] block: Add block device LED trigger integrations
    On Thu,  9 Sep 2021 17:25:02 -0500
    Ian Pilcher <arequipeno@gmail.com> wrote:

    > @@ -166,6 +166,9 @@ struct gendisk {
    > #endif /* CONFIG_BLK_DEV_INTEGRITY */
    > #if IS_ENABLED(CONFIG_CDROM)
    > struct cdrom_device_info *cdi;
    > +#endif
    > +#if IS_ENABLED(CONFIG_LEDS_TRIGGER_BLKDEV)
    > + struct ledtrig_blkdev_disk *ledtrig;
    > #endif

    So in this patch you are adding pointer to a structure, but the
    structure is introduced in a later patch (07/15).

    Please send these changes as one patch, it is easier to review.

    Marek

    \
     
     \ /
      Last update: 2021-09-10 03:38    [W:4.074 / U:0.252 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site