lkml.org 
[lkml]   [2021]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.14 95/99] kasan: test: disable kmalloc_memmove_invalid_size for HW_TAGS
    Date
    From: Andrey Konovalov <andreyknvl@gmail.com>

    [ Upstream commit 1b0668be62cfa394903bb368641c80533bf42d5a ]

    The HW_TAGS mode doesn't check memmove for negative size. As a result,
    the kmalloc_memmove_invalid_size test corrupts memory, which can result in
    a crash.

    Disable this test with HW_TAGS KASAN.

    Link: https://lkml.kernel.org/r/088733a06ac21eba29aa85b6f769d2abd74f9638.1628779805.git.andreyknvl@gmail.com
    Signed-off-by: Andrey Konovalov <andreyknvl@gmail.com>
    Reviewed-by: Marco Elver <elver@google.com>
    Cc: Alexander Potapenko <glider@google.com>
    Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
    Cc: Dmitry Vyukov <dvyukov@google.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    lib/test_kasan.c | 8 +++++++-
    1 file changed, 7 insertions(+), 1 deletion(-)

    diff --git a/lib/test_kasan.c b/lib/test_kasan.c
    index b298edb325ab..c149675300bd 100644
    --- a/lib/test_kasan.c
    +++ b/lib/test_kasan.c
    @@ -485,11 +485,17 @@ static void kmalloc_memmove_invalid_size(struct kunit *test)
    size_t size = 64;
    volatile size_t invalid_size = -2;

    + /*
    + * Hardware tag-based mode doesn't check memmove for negative size.
    + * As a result, this test introduces a side-effect memory corruption,
    + * which can result in a crash.
    + */
    + KASAN_TEST_NEEDS_CONFIG_OFF(test, CONFIG_KASAN_HW_TAGS);
    +
    ptr = kmalloc(size, GFP_KERNEL);
    KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ptr);

    memset((char *)ptr, 0, 64);
    -
    KUNIT_EXPECT_KASAN_FAIL(test,
    memmove((char *)ptr, (char *)ptr + 4, invalid_size));
    kfree(ptr);
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-09-10 02:47    [W:4.130 / U:0.296 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site