lkml.org 
[lkml]   [2021]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.14 01/99] pinctrl: renesas: rcar: Avoid changing PUDn when disabling bias
    Date
    From: Geert Uytterhoeven <geert+renesas@glider.be>

    [ Upstream commit 7ebaa41047738d46fca6376b3f1765ef69c463c5 ]

    When disabling pin bias, there is no need to touch the LSI pin
    pull-up/down control register (PUDn), which selects between pull-up and
    pull-down. Just disabling the pull-up/down function through the LSI pin
    pull-enable register (PUENn) is sufficient.

    Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
    Link: https://lore.kernel.org/r/071ec644de2555da593a4531ef5d3e4d79cf997d.1625064076.git.geert+renesas@glider.be
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pinctrl/renesas/pinctrl.c | 14 +++++++-------
    1 file changed, 7 insertions(+), 7 deletions(-)

    diff --git a/drivers/pinctrl/renesas/pinctrl.c b/drivers/pinctrl/renesas/pinctrl.c
    index bb488af29862..85cb78cfcfa6 100644
    --- a/drivers/pinctrl/renesas/pinctrl.c
    +++ b/drivers/pinctrl/renesas/pinctrl.c
    @@ -898,17 +898,17 @@ void rcar_pinmux_set_bias(struct sh_pfc *pfc, unsigned int pin,

    if (reg->puen) {
    enable = sh_pfc_read(pfc, reg->puen) & ~BIT(bit);
    - if (bias != PIN_CONFIG_BIAS_DISABLE)
    + if (bias != PIN_CONFIG_BIAS_DISABLE) {
    enable |= BIT(bit);

    - if (reg->pud) {
    - updown = sh_pfc_read(pfc, reg->pud) & ~BIT(bit);
    - if (bias == PIN_CONFIG_BIAS_PULL_UP)
    - updown |= BIT(bit);
    + if (reg->pud) {
    + updown = sh_pfc_read(pfc, reg->pud) & ~BIT(bit);
    + if (bias == PIN_CONFIG_BIAS_PULL_UP)
    + updown |= BIT(bit);

    - sh_pfc_write(pfc, reg->pud, updown);
    + sh_pfc_write(pfc, reg->pud, updown);
    + }
    }
    -
    sh_pfc_write(pfc, reg->puen, enable);
    } else {
    enable = sh_pfc_read(pfc, reg->pud) & ~BIT(bit);
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-09-10 02:16    [W:2.838 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site