Messages in this thread | | | From | Chaitanya Kulkarni <> | Subject | Re: [PATCH] n64cart: fix return value check in n64cart_probe() | Date | Thu, 9 Sep 2021 16:17:24 +0000 |
| |
On 9/9/21 2:06 AM, Yang Yingliang wrote: > External email: Use caution opening links or attachments > > > In case of error, the function devm_platform_ioremap_resource() > returns ERR_PTR() and never returns NULL. The NULL test in the > return value check should be replaced with IS_ERR(). > > Fixes: d9b2a2bbbb4d ("block: Add n64 cart driver") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
| |