Messages in this thread Patch in this message | | | From | Yu Kuai <> | Subject | [PATCH v5 6/6] nbd: don't start request if nbd_queue_rq() failed | Date | Thu, 9 Sep 2021 22:12:56 +0800 |
| |
Currently, blk_mq_end_request() will be called if nbd_queue_rq() failed, thus start request in such situation is useless.
Signed-off-by: Yu Kuai <yukuai3@huawei.com> Reviewed-by: Christoph Hellwig <hch@lst.de> --- drivers/block/nbd.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index d298e2b9e6ee..7a963c4ec0d1 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -943,7 +943,6 @@ static int nbd_handle_cmd(struct nbd_cmd *cmd, int index) if (!refcount_inc_not_zero(&nbd->config_refs)) { dev_err_ratelimited(disk_to_dev(nbd->disk), "Socks array is empty\n"); - blk_mq_start_request(req); return -EINVAL; } config = nbd->config; @@ -952,7 +951,6 @@ static int nbd_handle_cmd(struct nbd_cmd *cmd, int index) dev_err_ratelimited(disk_to_dev(nbd->disk), "Attempted send on invalid socket\n"); nbd_config_put(nbd); - blk_mq_start_request(req); return -EINVAL; } cmd->status = BLK_STS_OK; @@ -976,7 +974,6 @@ static int nbd_handle_cmd(struct nbd_cmd *cmd, int index) */ sock_shutdown(nbd); nbd_config_put(nbd); - blk_mq_start_request(req); return -EIO; } goto again; -- 2.31.1
| |