lkml.org 
[lkml]   [2021]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 092/109] cifs: fix wrong release in sess_alloc_buffer() failed path
    Date
    From: Ding Hui <dinghui@sangfor.com.cn>

    [ Upstream commit d72c74197b70bc3c95152f351a568007bffa3e11 ]

    smb_buf is allocated by small_smb_init_no_tc(), and buf type is
    CIFS_SMALL_BUFFER, so we should use cifs_small_buf_release() to
    release it in failed path.

    Signed-off-by: Ding Hui <dinghui@sangfor.com.cn>
    Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
    Signed-off-by: Steve French <stfrench@microsoft.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/cifs/sess.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/fs/cifs/sess.c b/fs/cifs/sess.c
    index 85bd644f9773..30f841a880ac 100644
    --- a/fs/cifs/sess.c
    +++ b/fs/cifs/sess.c
    @@ -610,7 +610,7 @@ sess_alloc_buffer(struct sess_data *sess_data, int wct)
    return 0;

    out_free_smb_buf:
    - kfree(smb_buf);
    + cifs_small_buf_release(smb_buf);
    sess_data->iov[0].iov_base = NULL;
    sess_data->iov[0].iov_len = 0;
    sess_data->buf0_type = CIFS_NO_BUFFER;
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-09-09 15:37    [W:9.009 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site