lkml.org 
[lkml]   [2021]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.10 104/176] net/mlx5: Fix variable type to match 64bit
    Date
    From: Eran Ben Elisha <eranbe@nvidia.com>

    [ Upstream commit 979aa51967add26b37f9d77e01729d44a2da8e5f ]

    Fix the following smatch warning:
    wait_func_handle_exec_timeout() warn: should '1 << ent->idx' be a 64 bit type?

    Use 1ULL, to have a 64 bit type variable.

    Reported-by: kernel test robot <lkp@intel.com>
    Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Eran Ben Elisha <eranbe@nvidia.com>
    Reviewed-by: Moshe Shemesh <moshe@nvidia.com>
    Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
    index e49387dbef98..2e55e0088871 100644
    --- a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
    +++ b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
    @@ -865,7 +865,7 @@ static void cb_timeout_handler(struct work_struct *work)
    ent->ret = -ETIMEDOUT;
    mlx5_core_warn(dev, "cmd[%d]: %s(0x%x) Async, timeout. Will cause a leak of a command resource\n",
    ent->idx, mlx5_command_str(msg_to_opcode(ent->in)), msg_to_opcode(ent->in));
    - mlx5_cmd_comp_handler(dev, 1UL << ent->idx, true);
    + mlx5_cmd_comp_handler(dev, 1ULL << ent->idx, true);

    out:
    cmd_ent_put(ent); /* for the cmd_ent_get() took on schedule delayed work */
    @@ -982,7 +982,7 @@ static void cmd_work_handler(struct work_struct *work)
    MLX5_SET(mbox_out, ent->out, status, status);
    MLX5_SET(mbox_out, ent->out, syndrome, drv_synd);

    - mlx5_cmd_comp_handler(dev, 1UL << ent->idx, true);
    + mlx5_cmd_comp_handler(dev, 1ULL << ent->idx, true);
    return;
    }

    @@ -996,7 +996,7 @@ static void cmd_work_handler(struct work_struct *work)
    poll_timeout(ent);
    /* make sure we read the descriptor after ownership is SW */
    rmb();
    - mlx5_cmd_comp_handler(dev, 1UL << ent->idx, (ent->ret == -ETIMEDOUT));
    + mlx5_cmd_comp_handler(dev, 1ULL << ent->idx, (ent->ret == -ETIMEDOUT));
    }
    }

    @@ -1056,7 +1056,7 @@ static void wait_func_handle_exec_timeout(struct mlx5_core_dev *dev,
    mlx5_command_str(msg_to_opcode(ent->in)), msg_to_opcode(ent->in));

    ent->ret = -ETIMEDOUT;
    - mlx5_cmd_comp_handler(dev, 1UL << ent->idx, true);
    + mlx5_cmd_comp_handler(dev, 1ULL << ent->idx, true);
    }

    static int wait_func(struct mlx5_core_dev *dev, struct mlx5_cmd_work_ent *ent)
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-09-09 15:07    [W:5.485 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site