Messages in this thread | | | From | Parshuram Raju Thombare <> | Subject | RE: [PATCH v3 1/2] spi: cadence: add dt-bindings documentation for Cadence XSPI controller | Date | Wed, 8 Sep 2021 06:52:37 +0000 |
| |
>This needs to be a "subclass" of the spi-controller.yaml binding. > >allOf: > - $ref: spi-controller.yaml#
Isn't stating that validation need against spi-controller.yaml as well as this schema sufficient ? Can you please point an example how to make controller binding a "subclass" of spi-controller.yaml binding ?
>Node name should be flash@0.
I think spi-controller.yaml uses wildcard for the name of a device node, so anything in string@hexvalue: should work.
>> + compatible = "spi-nor", "micron,mt35xu512"; > >These compatibles are arbitrary and undocumented. You probably just need >"jedec,spi-nor". If you need anything else, you need to justify why.
Although just "spi-nor" also works, I agree to use "jedec, spi-nor" and drop device name.
Regards, Parshuram Thombare
| |