lkml.org 
[lkml]   [2021]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v3 1/2] spi: cadence: add dt-bindings documentation for Cadence XSPI controller
Date
>This needs to be a "subclass" of the spi-controller.yaml binding.
>
>allOf:
> - $ref: spi-controller.yaml#

Isn't stating that validation need against spi-controller.yaml as well as
this schema sufficient ? Can you please point an example how to make
controller binding a "subclass" of spi-controller.yaml binding ?

>Node name should be flash@0.

I think spi-controller.yaml uses wildcard for the name of a device node,
so anything in string@hexvalue: should work.

>> + compatible = "spi-nor", "micron,mt35xu512";
>
>These compatibles are arbitrary and undocumented. You probably just need
>"jedec,spi-nor". If you need anything else, you need to justify why.

Although just "spi-nor" also works, I agree to use "jedec, spi-nor" and drop
device name.

Regards,
Parshuram Thombare

\
 
 \ /
  Last update: 2021-09-08 08:53    [W:0.079 / U:1.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site