Messages in this thread | | | Subject | Re: [PATCH net] net: stmmac: fix system hang caused by eee_ctrl_timer during suspend/resume | From | patchwork-bot+netdevbpf@kernel ... | Date | Wed, 08 Sep 2021 11:40:05 +0000 |
| |
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Wed, 8 Sep 2021 15:43:35 +0800 you wrote: > commit 5f58591323bf ("net: stmmac: delete the eee_ctrl_timer after > napi disabled"), this patch tries to fix system hang caused by eee_ctrl_timer, > unfortunately, it only can resolve it for system reboot stress test. System > hang also can be reproduced easily during system suspend/resume stess test > when mount NFS on i.MX8MP EVK board. > > In stmmac driver, eee feature is combined to phylink framework. When do > system suspend, phylink_stop() would queue delayed work, it invokes > stmmac_mac_link_down(), where to deactivate eee_ctrl_timer synchronizly. > In above commit, try to fix issue by deactivating eee_ctrl_timer obviously, > but it is not enough. Looking into eee_ctrl_timer expire callback > stmmac_eee_ctrl_timer(), it could enable hareware eee mode again. What is > unexpected is that LPI interrupt (MAC_Interrupt_Enable.LPIEN bit) is always > asserted. This interrupt has chance to be issued when LPI state entry/exit > from the MAC, and at that time, clock could have been already disabled. > The result is that system hang when driver try to touch register from > interrupt handler. > > [...]
Here is the summary with links: - [net] net: stmmac: fix system hang caused by eee_ctrl_timer during suspend/resume https://git.kernel.org/netdev/net/c/276aae377206
You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
| |