Messages in this thread | | | Subject | Re: [PATCH v3] Input: analog: Always use ktime functions | From | Guenter Roeck <> | Date | Tue, 7 Sep 2021 19:29:36 -0700 |
| |
On 9/7/21 6:43 PM, Dmitry Torokhov wrote: > Hi Guenter, > > On Tue, Sep 07, 2021 at 05:37:34AM -0700, Guenter Roeck wrote: >> @@ -241,11 +176,11 @@ static int analog_cooked_read(struct analog_port *port) >> int i, j; >> >> loopout = (ANALOG_LOOP_TIME * port->loop) / 1000; >> - timeout = ANALOG_MAX_TIME * port->speed; >> + timeout = ANALOG_MAX_TIME * NSEC_PER_MSEC; >> >> local_irq_save(flags); >> gameport_trigger(gameport); >> - now = get_time(); >> + now = ktime_get(); > > There are time[4], now, etc variables above this block that are u64. I > think they can be make ktime_t. I can do it myself if you agree. > Sure.
>> @@ -378,35 +313,19 @@ static void analog_calibrate_timer(struct analog_port *port) >> u64 t1, t2, t3; > > I think these should also be ktime_t. > Ok. Do you want me to resend or are you going to make the changes ?
Thanks, Guenter
| |