Messages in this thread | | | Date | Tue, 7 Sep 2021 09:08:01 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCH][next] ksmbd: add missing assignments to ret on ndr_read_int64 read calls |
| |
On (21/09/06 14:44), Colin King wrote: [..] > @@ -275,11 +275,11 @@ int ndr_decode_dos_attr(struct ndr *n, struct xattr_dos_attrib *da) > if (ret) > return ret; > > - ndr_read_int64(n, NULL); > + ret = ndr_read_int64(n, NULL); > if (ret) > return ret; > > - ndr_read_int64(n, NULL); > + ret = ndr_read_int64(n, NULL); > if (ret) > return ret;
A pretty nice catch by that static analyzer tool.
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
| |