Messages in this thread | | | Subject | Re: [PATCH] block: include dd_queued{,_show} into proper BLK_DEBUG_FS guard | From | Jens Axboe <> | Date | Mon, 6 Sep 2021 11:39:52 -0600 |
| |
On 9/6/21 11:36 AM, Julio Faracco wrote: > Thanks Jens. > > On Mon, Sep 6, 2021 at 1:44 PM Jens Axboe <axboe@kernel.dk> wrote: >> >> On 9/6/21 10:38 AM, Julio Faracco wrote: >>> This commit fixes a compilation issue to an unused function if >>> BLK_DEBUG_FS setting is not enabled. This usually happens in tiny >>> kernels with several debug options disabled. For further details, >>> see the message below: >>> >>> ../block/mq-deadline.c:274:12: error: ‘dd_queued’ defined but not used [-Werror=unused-function] >>> 274 | static u32 dd_queued(struct deadline_data *dd, enum dd_prio prio) >>> | ^~~~~~~~~ >>> cc1: all warnings being treated as errors >> >> This is like the 10th one of these... The patch has been queued up for >> about a week, if you check linux-next or the block tree. It's going >> upstream soon, in fact it was already sent in yesterday. > > I noticed after seeing the same patch earlier this morning, but it was > too late to undo. > Discard my patch, pls.
No worries - fwiw, the fix is upstream now.
-- Jens Axboe
| |