Messages in this thread | | | Subject | Re: [PATCH] staging: rtl8712: Move similar execution in to a function. | From | Saurav Girepunje <> | Date | Mon, 6 Sep 2021 22:20:05 +0530 |
| |
On 06/09/21 3:15 pm, Greg KH wrote: > On Mon, Sep 06, 2021 at 12:15:57AM +0530, Saurav Girepunje wrote: >> Move the common execution for read_macreg_hdl, write_macreg_hdl, >> write_bbreg_hdl and write_rfreg_hdl in to a new function >> common_read_write_hdl. > > You said _what_ you did here, but not _why_ you did this. > > I can't easily see why you did this, please explain it better in the > next version of this patch. > > thanks, > > greg k-h >
Ok, I will add explanation and send next version.
Thanks for review greg.
Regards, Saurav Girepunje
| |