lkml.org 
[lkml]   [2021]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V2 2/2] arm64: dts: sc7280: Add volume up support for sc7280-idp
    On 2021-09-03 23:42, Stephen Boyd wrote:
    > Quoting satya priya (2021-09-02 02:15:06)
    >> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
    >> b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
    >> index 371a2a9..52bcbbc 100644
    >> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
    >> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
    >> @@ -199,6 +199,37 @@
    >> modem-init;
    >> };
    >>
    >> +&soc {
    >
    > 's' comes after 'p' so this is in the wrong place.
    >

    Okay will move it accordingly.

    >> + gpio_keys {
    >> + compatible = "gpio-keys";
    >> + label = "gpio-keys";
    >> +
    >> + pinctrl-names = "default";
    >> + pinctrl-0 = <&key_vol_up_default>;
    >> +
    >> + vol_up {
    >> + label = "volume_up";
    >> + gpios = <&pm7325_gpios 6 GPIO_ACTIVE_LOW>;
    >> + linux,input-type = <1>;
    >> + linux,code = <KEY_VOLUMEUP>;
    >> + gpio-key,wakeup;
    >> + debounce-interval = <15>;
    >> + linux,can-disable;
    >> + };
    >> + };
    >> +};
    >> +
    >> +&pm7325_gpios {
    >> + key_vol_up_default: key_vol_up_default {
    >
    > Please move this to the "PINCTRL - additions to nodes defined in
    > sc7280.dtsi" section and then sort alphabetically on node naem.
    >

    Okay.

    >> + pins = "gpio6";
    >> + function = "normal";
    >> + input-enable;
    >> + bias-pull-up;
    >> + power-source = <0>;
    >> + qcom,drive-strength = <3>;
    >> + };
    >> +};
    >> +
    >> &pmk8350_vadc {
    >> pmk8350_die_temp {
    >> reg = <PMK8350_ADC7_DIE_TEMP>;

    \
     
     \ /
      Last update: 2021-09-06 12:59    [W:4.790 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site