lkml.org 
[lkml]   [2021]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE:(2) [PATCH] zram_drv: allow reclaim on bio_alloc
From
Date
> 
>
>--------- Original Message ---------
>Sender : Christoph Hellwig <hch@infradead.org>
>Date : 2021-09-06 17:39 (GMT+9)
>Title : Re: [PATCH] zram_drv: allow reclaim on bio_alloc
>
>On Mon, Sep 06, 2021 at 02:29:26PM +0900, Jaewon Kim wrote:
>> The read_from_bdev_async is not called on atomic context. So GFP_NOIO is
>> available rather than GFP_ATOMIC. If there were reclaimable pages with
>> GFP_NOIO, we can avoid allocation failure and page fault failure.
>>
>> Reported-by: Yong-Taek Lee <ytk.lee@samsung.com>
>> Signed-off-by: Jaewon Kim <jaewon31.kim@samsung.com>
>> ---
>> drivers/block/zram/zram_drv.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
>> index fcaf2750f68f..53be528a39a2 100644
>> --- a/drivers/block/zram/zram_drv.c
>> +++ b/drivers/block/zram/zram_drv.c
>> @@ -587,7 +587,7 @@ static int read_from_bdev_async(struct zram *zram, struct bio_vec *bvec,
>> {
>> struct bio *bio;
>>
>> - bio = bio_alloc(GFP_ATOMIC, 1);
>> + bio = bio_alloc(GFP_NOIO|__GFP_HIGHMEM, 1);
>
>Passing __GFP_HIGHMEM to bio_alloc does not make any sense whatsoever.
>
Correct, let me remove __GFP_HIGHMEM if I send v2 patch.
Thank you

\
 
 \ /
  Last update: 2021-09-06 11:15    [W:0.092 / U:1.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site