lkml.org 
[lkml]   [2021]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] dt-bindings: display: renesas,du: Provide bindings for r8a779a0
Hi Kieran,

On Thu, Sep 2, 2021 at 1:39 AM Kieran Bingham
<kieran.bingham@ideasonboard.com> wrote:
> From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>
> Extend the Renesas DU display bindings to support the r8a779a0 V3U.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> v2:
> - Collected Laurent's tag
> - Remove clock-names requirement
> - Specify only a single clock

Thanks for the update!

> --- a/Documentation/devicetree/bindings/display/renesas,du.yaml
> +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml
> @@ -39,6 +39,7 @@ properties:
> - renesas,du-r8a77980 # for R-Car V3H compatible DU
> - renesas,du-r8a77990 # for R-Car E3 compatible DU
> - renesas,du-r8a77995 # for R-Car D3 compatible DU
> + - renesas,du-r8a779a0 # for R-Car V3U compatible DU
>
> reg:
> maxItems: 1
> @@ -773,6 +774,55 @@ allOf:
> - reset-names
> - renesas,vsps
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - renesas,du-r8a779a0
> + then:
> + properties:
> + clocks:
> + items:
> + - description: Functional clock
> +
> + clock-names:
> + maxItems: 1
> + items:
> + - const: du
> +
> + interrupts:
> + maxItems: 2
> +
> + resets:
> + maxItems: 1
> +
> + reset-names:
> + items:
> + - const: du.0

This is now inconsistent with clock-names, which doesn't use a suffix.

> +
> + ports:
> + properties:
> + port@0:
> + description: DSI 0
> + port@1:
> + description: DSI 1
> + port@2: false
> + port@3: false
> +
> + required:
> + - port@0
> + - port@1
> +
> + renesas,vsps:
> + minItems: 2
> +
> + required:
> + - interrupts
> + - resets
> + - reset-names

Same here, as clock-names is not required anymore.

> + - renesas,vsps
> +
> additionalProperties: false
>
> examples:

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2021-09-06 10:15    [W:0.067 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site