Messages in this thread | | | Date | Thu, 30 Sep 2021 20:33:44 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH V6 5/8] x86/hyperv: Add Write/Read MSR registers via ghcb page |
| |
On Thu, Sep 30, 2021 at 01:27:20PM -0500, Tom Lendacky wrote: > > + if ((ghcb->save.sw_exit_info_1 & 0xffffffff) == 1) > > Really, any non-zero value indicates an error, so this should be: > > if (ghcb->save.sw_exit_info_1 & 0xffffffff)
That's ok but that should be a separate patch - first patch splits the function and second changes the functionality.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |