Messages in this thread | | | Date | Thu, 30 Sep 2021 16:26:18 +0100 | From | Jonathan Cameron <> | Subject | Re: [PATCH 1/1] iio/scmi: Add reading "raw" attribute. |
| |
> >> + /* Use 32-bit value, since practically there is no need in 64 bits */ > >> + *val = (u32)readings[ch->scan_index].value; > > We should check it fits and if doesn't return an error rather than pretending all was fine. > > > What kind of error to return in the case it does not fit - ENOEXEC (Exec format error) ?
That one is a bit obscure.
I'd go with either -ERANGE I think as we are reflecting that the clamp to 32 bit is not representable.
| |