Messages in this thread | | | Date | Thu, 30 Sep 2021 08:55:53 +0300 | Subject | Re: [PATCH v2 2/2] phy: mdio: fix memory leak | From | Pavel Skripkin <> |
| |
On 9/30/21 02:48, Jakub Kicinski wrote: > On Tue, 28 Sep 2021 23:40:15 +0300 Pavel Skripkin wrote: >> + /* We need to set state to MDIOBUS_UNREGISTERED to correctly realese >> + * the device in mdiobus_free() >> + * >> + * State will be updated later in this function in case of success >> + */ >> + bus->state == MDIOBUS_UNREGISTERED; > > IDK how syzbot has tested it but clearly we should blindly > depend on that. > > s/==/=/ > > Compiler would have told you this. > whooops... sorry about that. syzbot has tested v1. v2 is same, but without new state (so, the logic in v1 and v2 is the same).
I guess, it's copy-paste error on my side :). Will send v3 this evening
With regards, Pavel Skripkin
| |