lkml.org 
[lkml]   [2021]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 2/2] phy: mdio: fix memory leak
From
On 9/30/21 02:48, Jakub Kicinski wrote:
> On Tue, 28 Sep 2021 23:40:15 +0300 Pavel Skripkin wrote:
>> + /* We need to set state to MDIOBUS_UNREGISTERED to correctly realese
>> + * the device in mdiobus_free()
>> + *
>> + * State will be updated later in this function in case of success
>> + */
>> + bus->state == MDIOBUS_UNREGISTERED;
>
> IDK how syzbot has tested it but clearly we should blindly
> depend on that.
>
> s/==/=/
>
> Compiler would have told you this.
>
whooops... sorry about that. syzbot has tested v1. v2 is same, but
without new state (so, the logic in v1 and v2 is the same).

I guess, it's copy-paste error on my side :). Will send v3 this evening



With regards,
Pavel Skripkin

\
 
 \ /
  Last update: 2021-09-30 07:57    [W:0.260 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site