Messages in this thread | | | From | Pasha Tatashin <> | Date | Wed, 29 Sep 2021 23:57:59 -0400 | Subject | Re: [PATCH v17 10/15] arm64: kexec: use ld script for relocation function |
| |
On Wed, Sep 29, 2021 at 8:45 AM Will Deacon <will@kernel.org> wrote: > > On Thu, Sep 16, 2021 at 07:13:20PM -0400, Pasha Tatashin wrote: > > Currently, relocation code declares start and end variables > > which are used to compute its size. > > > > The better way to do this is to use ld script incited, and put relocation > > function in its own section. > > "incited"? I don't understand ...
I will correct it: s/incited//
> > +#ifdef CONFIG_KEXEC_CORE > > +/* kexec relocation code should fit into one KEXEC_CONTROL_PAGE_SIZE */ > > +ASSERT(__relocate_new_kernel_end - (__relocate_new_kernel_start & ~(SZ_4K - 1)) > > + <= SZ_4K, "kexec relocation code is too big or misaligned") > > +ASSERT(KEXEC_CONTROL_PAGE_SIZE >= SZ_4K, "KEXEC_CONTROL_PAGE_SIZE is brokern") > > Typo: "brokern",
Will correct it.
Thanks, Pasha
| |