Messages in this thread | | | Subject | Re: [PATCH 1/2] usb: hub: Mark root hubs on removable devices, as removable. | From | Oliver Neukum <> | Date | Thu, 30 Sep 2021 10:02:00 +0200 |
| |
On 30.09.21 00:48, Rajat Jain wrote: > Currently all usb root hubs are always marked as DEVICE_REMOVABLE_UNKNOWN > unconditionally. Let us try to help the users to identify the removable > root hubs, by checking the device on which the root hub sits. If the base > (parent) device on which the root hub sits, is removable (e.g. on > thunderbolt docks), then the roothub is also marked as removable. > > Signed-off-by: Rajat Jain <rajatja@google.com>
Hi,
frankly, why? You are needlessly throwing away information about where in the tree removal can happen. This looks like a worsening, not an improvement to me.
Regards Oliver
| |