Messages in this thread | | | Subject | Re: [PATCH 0/5] platform/chrome: Make cros_ec_pd_command() reusable | From | Enric Balletbo i Serra <> | Date | Thu, 30 Sep 2021 09:25:51 +0200 |
| |
Hi Prashant,
On 30/9/21 4:23, Prashant Malani wrote: > This is a short series to relocate and rename cros_ec_pd_command() to > cros_ec_proto.c. This function is useful for sending host command > messages, so the 1st 4 patches move it a more central location, and > modify the arguments to allow other users to use it. >
Nice patchset! let's hope we can remove at some point all the custom implementations in the different cros_ec drivers of the cros_ec_command function. Give some days to run some tests.
Thanks, Enric
> The final patch updates cros-ec-typec to use the new function and get > rid of its own copy. > > Prashant Malani (5): > platform/chrome: cros_usbpd_notify: Rename cros_ec_pd_command() > platform/chrome: cros_usbpd_notify: Move ec_command() > platform/chrome: cros_ec_proto: Make data pointers void > platform/chrome: cros_ec_proto: Add version for ec_command > platform/chrome: cros_ec_typec: Use cros_ec_command() > > drivers/platform/chrome/cros_ec_proto.c | 48 ++++++++++++++ > drivers/platform/chrome/cros_ec_typec.c | 69 ++++++--------------- > drivers/platform/chrome/cros_usbpd_notify.c | 50 +-------------- > include/linux/platform_data/cros_ec_proto.h | 3 + > 4 files changed, 72 insertions(+), 98 deletions(-) >
| |