Messages in this thread | | | From | Arnd Bergmann <> | Date | Thu, 30 Sep 2021 09:21:40 +0200 | Subject | Re: [PATCH v2 2/3] acornscsi: remove tagged queuing vestiges |
| |
On Wed, Sep 15, 2021 at 11:16 AM John Garry <john.garry@huawei.com> wrote: > > From: Hannes Reinecke <hare@suse.de> > > The acornscsi driver has a config option to enable tagged queuing, > but this option gets disabled in the driver itself with the comment > 'needs to be debugged'. > As this is a _really_ old driver I doubt anyone will be wanting to > invest time here, so remove the tagged queue vestiges and make > our live easier. > > Signed-off-by: Hannes Reinecke <hare@suse.de> > jpg: Use scsi_cmd_to_rq() > Signed-off-by: John Garry <john.garry@huawei.com>
A few thousand randconfig builds later, I actually came across building this driver.
> @@ -1821,7 +1776,7 @@ int acornscsi_reconnect_finish(AS_Host *host) > host->scsi.disconnectable = 0; > if (host->SCpnt->device->id == host->scsi.reconnected.target && > host->SCpnt->device->lun == host->scsi.reconnected.lun && > - host->SCpnt->tag == host->scsi.reconnected.tag) { > + scsi_cmd_to_tag(host->SCpnt) == host->scsi.reconnected.tag) { > #if (DEBUG & (DEBUG_QUEUES|DEBUG_DISCON)) > DBG(host->SCpnt, printk("scsi%d.%c: reconnected", > host->host->host_no, acornscsi_target(host)));
drivers/scsi/arm/acornscsi.c: In function 'acornscsi_reconnect_finish': drivers/scsi/arm/acornscsi.c:1779:6: error: implicit declaration of function 'scsi_cmd_to_tag'; did you mean 'scsi_cmd_to_rq'? [-Werror=implicit-function-declaration] scsi_cmd_to_tag(host->SCpnt) == host->scsi.reconnected.tag) { ^~~~~~~~~~~~~~~ scsi_cmd_to_rq
I have no idea what this is meant to do instead, but scsi_cmd_to_tag() does not appear to be defined in any kernel I can find.
Arnd
| |