Messages in this thread | | | Date | Fri, 1 Oct 2021 00:16:23 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 2/2] mwifiex: Try waking the firmware until we get an interrupt |
| |
On Thu, Sep 30, 2021 at 11:07:09PM +0200, Jonas Dreßler wrote: > On 9/30/21 10:58 PM, Andy Shevchenko wrote: > > On Thu, Sep 30, 2021 at 08:04:00PM +0200, Jonas Dreßler wrote:
...
> > Second, what is the problem with having one write more or less? > > Your current code doesn't guarantee this either. It only decreases > > probability of such scenario. Am I wrong? > > Indeed my approach just decreases the probability and we sometimes end up > writing twice to wakeup the card, but it would kinda bug me if we'd always > do one write too much. > > Anyway, if you still prefer the read_poll_timeout() solution I'd be alright > with that of course.
Yes, it will make code cleaner.
-- With Best Regards, Andy Shevchenko
| |