lkml.org 
[lkml]   [2021]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 2/2] mwifiex: Try waking the firmware until we get an interrupt
    On Thu, Sep 30, 2021 at 11:07:09PM +0200, Jonas Dreßler wrote:
    > On 9/30/21 10:58 PM, Andy Shevchenko wrote:
    > > On Thu, Sep 30, 2021 at 08:04:00PM +0200, Jonas Dreßler wrote:

    ...

    > > Second, what is the problem with having one write more or less?
    > > Your current code doesn't guarantee this either. It only decreases
    > > probability of such scenario. Am I wrong?
    >
    > Indeed my approach just decreases the probability and we sometimes end up
    > writing twice to wakeup the card, but it would kinda bug me if we'd always
    > do one write too much.
    >
    > Anyway, if you still prefer the read_poll_timeout() solution I'd be alright
    > with that of course.

    Yes, it will make code cleaner.

    --
    With Best Regards,
    Andy Shevchenko


    \
     
     \ /
      Last update: 2021-09-30 23:17    [W:4.510 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site