lkml.org 
[lkml]   [2021]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] serial: 8250_dw: Mark acpi match table as maybe unused
    On Fri, Oct 01, 2021 at 12:31:34AM +0900, Daniel Palmer wrote:
    > On Fri, 1 Oct 2021 at 00:24, Andy Shevchenko
    > <andriy.shevchenko@linux.intel.com> wrote:
    > > And incorrect fix. See my patches regarding to the topic
    > > (`git log --grep ACPI_PTR`) and do accordingly, i.e. drop
    > > ACPI_PTR() for good.
    >
    > Something like 349bff48ae0f5f8aa2075d0bdc2091a30bd634f6?
    >
    > Doesn't this mean the ACPI table ends up in kernels that will never use ACPI?

    Yes. Is it a problem (*)? If so, you need to use ifdeffery, since __maybe_unused is
    not for the ID tables.

    *) while justifying this you also need to show why it's a problem specific
    to the ACPI IDs and not a problem for OF ones, which we have tons of in the
    Linux kernel without any guards (ifdeffery).

    --
    With Best Regards,
    Andy Shevchenko


    \
     
     \ /
      Last update: 2021-09-30 23:05    [W:3.110 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site