lkml.org 
[lkml]   [2021]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v5 10/14] arm64: apple: Add pinctrl nodes
    On Wed, Sep 29, 2021 at 6:56 PM Marc Zyngier <maz@kernel.org> wrote:

    > From: Mark Kettenis <kettenis@openbsd.org>
    >
    > Add pinctrl nodes corresponding to the gpio,t8101 nodes in the
    > Apple device tree for the Mac mini (M1, 2020).
    >
    > Clock references are left out at the moment and will be added once
    > the appropriate bindings have been settled upon.
    >
    > Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
    > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
    > Signed-off-by: Marc Zyngier <maz@kernel.org>
    > Link: https://lore.kernel.org/r/20210520171310.772-3-mark.kettenis@xs4all.nl
    (...)
    > + pinctrl_ap: pinctrl@23c100000 {
    > + compatible = "apple,t8103-pinctrl", "apple,pinctrl";
    > + reg = <0x2 0x3c100000 0x0 0x100000>;
    > +
    > + gpio-controller;
    > + #gpio-cells = <2>;
    > + gpio-ranges = <&pinctrl_ap 0 0 212>;

    In other discussions it turns out that the driver is abusing these gpio-ranges
    to find out how many pins are in each pinctrl instance. This is not the
    idea with gpio-ranges, these can be multiple and map different sets,
    so we need something like

    apple,npins = <212>;
    (+ bindings)

    or so...

    Yours,
    Linus Walleij

    \
     
     \ /
      Last update: 2021-09-29 21:06    [W:2.496 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site