lkml.org 
[lkml]   [2021]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 8/9] iio: adc: rockchip_saradc: Make use of the helper function dev_err_probe()
    Date
    When possible use dev_err_probe help to properly deal with the
    PROBE_DEFER error, the benefit is that DEFER issue will be logged
    in the devices_deferred debugfs file.
    Using dev_err_probe() can reduce code size, and the error value
    gets printed.

    Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
    ---
    v1->v2: Remove the separate line of PTR_ERR().

    drivers/iio/adc/rockchip_saradc.c | 8 +++-----
    1 file changed, 3 insertions(+), 5 deletions(-)

    diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
    index a56a0d7337ca..57419ccb3c70 100644
    --- a/drivers/iio/adc/rockchip_saradc.c
    +++ b/drivers/iio/adc/rockchip_saradc.c
    @@ -392,11 +392,9 @@ static int rockchip_saradc_probe(struct platform_device *pdev)
    }

    info->vref = devm_regulator_get(&pdev->dev, "vref");
    - if (IS_ERR(info->vref)) {
    - dev_err(&pdev->dev, "failed to get regulator, %ld\n",
    - PTR_ERR(info->vref));
    - return PTR_ERR(info->vref);
    - }
    + if (IS_ERR(info->vref))
    + return dev_err_probe(&pdev->dev, PTR_ERR(info->vref),
    + "failed to get regulator\n");

    if (info->reset)
    rockchip_saradc_reset_controller(info->reset);
    --
    2.25.1
    \
     
     \ /
      Last update: 2021-09-28 16:20    [W:4.360 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site