Messages in this thread | | | From | Linus Walleij <> | Date | Tue, 28 Sep 2021 15:50:36 +0200 | Subject | Re: [PATCH v2 7/9] iio: adc: qcom-pm8xxx-xoadc: Make use of the helper function dev_err_probe() |
| |
On Tue, Sep 28, 2021 at 3:37 AM Cai Huoqing <caihuoqing@baidu.com> wrote:
> When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > Using dev_err_probe() can reduce code size, and the error value > gets printed. > > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> (...) > - return -ENXIO; > + return -ENODEV;
Why?
I think it's the right change, but should be in the changelog.
Yours, Linus Walleij
| |