Messages in this thread | | | Subject | Re: [PATCH v2] scsi: advansys: Prefer struct_size over open coded arithmetic | From | "Martin K. Petersen" <> | Date | Tue, 28 Sep 2021 22:55:12 -0400 |
| |
Len,
> As noted in the "Deprecated Interfaces, Language Features, Attributes, > and Conventions" documentation [1], size calculations (especially > multiplication) should not be performed in memory allocator (or > similar) function arguments due to the risk of them overflowing. This > could lead to values wrapping around and a smaller allocation being > made than the caller was expecting. Using those allocations could lead > to linear overflows of heap memory and other misbehaviors.
Applied to 5.16/scsi-staging, thanks!
-- Martin K. Petersen Oracle Linux Engineering
| |